Refactor analyze, add quality module and deprecate cohp module (replaced by coxx)#428
Merged
naik-aakash merged 45 commits intoJaGeo:mainfrom May 6, 2026
Merged
Conversation
1 task
…s AllCoordinationGeometries
…of deprecating class
naik-aakash
changed the title
JaGeo
approved these changes
May 6, 2026
Owner
JaGeo
left a comment
JaGeo
left a comment
There was a problem hiding this comment.
With the moved files, I cannot make a thorough review. However, I assume everything is still working as the tests run and pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
path_to_*inAnalyze.__init__classfrom_files,from_directory,as_dictandfrom_dictmethod toAnalyze.__init__classutils.pymodule and move some functions fromfeaturize.utilsin this new moduleAllCoordinationGeometriesfrom pymatgen insteadon_errorvariable instead when gettingLSE(It is taken care of in pymatgen LobsterNeighbors via this PR Simplify and clean up LobsterNeighbors materialsproject/pymatgen#4482 )